OpenSourceRouting
  1. OpenSourceRouting

quagga-snap

Public
AuthorCommitMessageCommit dateIssues
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
10f9bf3f202bgpd: optimize bgp_nexthop_self() This function scores 2nd, profiling a full internet table load. It's called for every prefix received. Instead of looping in the interface lists comparing addresses use a hash to mantain them. * bgpd.c: Init the own address hash. * bgp_nexthop.c: Introduce methods to maintain an own address hash. (bgp_connected_add) add addresses to the hash. (bgp_connected_delete) delete addresses fro...
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
f669f7d25f0bgpd: optimize aspath string representation and assegments handling* bgp_aspath.h: Add str_len to struct aspath. * bgp_aspath.c: Save the aspath string representation length and use it instead of strlen(). (aspath_make_str_count) assign the string buffer directly for consistency with the string length and change the return type to void. (aspath_dup) use str_len and copy the string instead of calling aspath_make_str_count(). (assegment_data_new) cha...
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
8692c506520bgpd: fix crash with vpnv4 soft-reconfigurationbgp_afi_node_get() expects a non-NULL prd for a SAFI_MPLS_VPN prefix. * bgp_route.c: pass down the struct prefix_rd from bgp_soft_reconfig_in() and bgp_soft_reconfig_rsclient(). Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
1b79fcb646flib: fix thread_cancel_event() ospfd was crashing some times on neighbour going down. The cause was that ospf_nsm_event() was accessing already freed memory in ospf_nbr_delete() call from ospf_nsm_event(). What happens is that since commit b5043aab (lib: fix incorrect thread list...) now a thread can be on the event and ready lists but thread_cancel_event() doesn't account for that. * thread.c: (thread_cancel_event) lo...
Roman Hoog AntinkDavid LamparterRoman Hoog Antink
7c9c6aebe8dlib: drop heuristic IPv6 address recognition* command.c: (cmd_ipv6_match) Drop IPv6 address recognition heuristics and solely rely on inet_pton, because strings like "abcd" were mistaken for IPv6 addresses. This affects e.g. the command "neighbour WORD peer-group", which won't work with words consisting of up to 4 characters between 'a' and 'f' and digits. From: Roman Hoog Antink <rha@open.ch> [full delete instead of #if 0] Si...
Joachim NilssonDavid LamparterJoachim Nilsson
36735ed988fzebra: fix up compilation without rtadv/IPv6let's ground the rtadv.h file if route advertisements are disabled. And fix up the CLI for it, as well as move the "show ip mroute" to its proper place. * zebra/rtadv.h: #ifdef RTADV * zebra/main.c: #ifdef RTADV * zebra/zebra_vty.c: move "show ip mroute" out of #ifdef IPV6 From: Joachim Nilsson <troglobit@gmail.com> [moved #ifdef RTADV to rtadv.h] Signed-off-by: David Lamparter <equinox...
G.BalajiDavid LamparterG.Balaji
42cb6b6655dzebra: feed Connected routes into MRIBThe SAFI_MULTICAST RIB needs to contain Connected routes so that the nexthop lookup does not fail and so that multicast routing daemons do not need to sidestep and look into SAFI_UNICAST to be aware of connected subnets. * zebra/connected.c: add & delete connected in SAFI_MULTICAST Signed-off-by: G.Balaji <balajig81@gmail.com> [merged add/delete patches] Signed-off-by: David Lamparter <equi...
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
a4c06dec1ebzebra: no need to clear memory of the netlink buffersThe memory is always written before sending. Clearing it before use slows netlink_route_multipath() down considerably and it's pretty noticeable in a full-internet table scenario loading. * zebra/rt_netlink.c: subtract bulk buffer size from clear Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> [reworded commit message] Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
682ca04c403bgpd: cleanup, use correct buffer sizes for sockunion2str()Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
37beff6feb7lib: remove sockunion related unused definitionsSigned-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
128293286a8lib, zebra: extend use of sockunion2ip macro * lib/sockunion.c, * zebra/zebra_rib.c: replace ->sin.sin_addr.s_addr with sockunion2ip Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> [reworded commit message] Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
c63b83fe8d1bgpd: Fix memory leak of some "show ip bgp neighbor" commandssockunion_str2su() use is prone to memory leaks. Remove it's use all over the code. At least these commands leaked a sockunion union: - show ip bgp vpnv4 ... routes - show ip bgp ... received prefix-filter Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
d227617a972lib: remove last uses of sockunion_su2str()Use of this function is prone to memory leaks. This fixes a memory accounting bug for vty denied connections. Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
0c5ed3ed00fbgpd: Fix memory leak with 'set ip next-hop peer-address'A route-map with the mentioned statement causes a memory leak for every prefix that matches. Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
4fe080d7ee4bgpd: fix for route-maps with "match peer local" statementsA route-map with a 'match peer local' statement it's shown like 'match peer (null)' on config output... ... and it's unparsable on daemon startup. Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
ddc943dec3cbgpd, zebra: Fix format for some metric outputsMetrics are unsigned values. * bgpd/bgp_{debug,route,vty}.c, * zebra/zebra_vty.c: replace %d with %u for metrics & distances Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> [reworded commit message] Signed-off-by: David Lamparter <equinox@diac24.net>
Paul JakmaPaul Jakma
8794e8d229dbgpd: Fix regression in args consolidation, total should be inited from args* bgp_attr.c: (bgp_attr_unknown) total should be initialised from the args.
Paul JakmaPaul Jakma
7621f336e2fbgpd: Make socket init separate, so unit tests work again.* Separate out BGP socket initialisation from bgp_get, and make it an explicit function. Allows unit tests to work again and probably also benefits dry-run. * bgpd.c: (bgp_get) move socket init out... (bgp_socket_init) to here * bgp_main.c: and call it after dry-run. * bgpd.h: (bgp_socket_init) add prototype
Paul JakmaPaul Jakma
1dba254e107tests: Fix some compile errors and warnings* aspath_test.c: match changes in aspath_unintern. Fix printf size_t warning. * bgp_capability_test.c: compile warnings. * bgp_mp_attr_test.c: update for attr parser context struct * ecommunity_test.c: ecommunity_free/ecommunity * test-checksum.c: some unused vars and funcs without need of prototypes.
Paul JakmaPaul Jakma
6ebeebb5061Revert "tests: disable broken tests/bgp_mp_attr_test.c"This reverts commit d78e2b8b562f8496aaf2977f7371415b71e82433. Next 2 commits fix it.
David LamparterDavid Lamparter
828f235df4brelease: 0.99.21
David LamparterDavid Lamparter
d78e2b8b562tests: disable broken tests/bgp_mp_attr_test.cit doesn't compile currently; it'll be fixed after the 0.99.21 release. * tests/bgp_mp_attr_test.c: wrap in #if 0 for now Signed-off-by: David Lamparter <equinox@diac24.net>
David WardDavid LamparterDavid Ward
4b5a2103b7dredhat: add systemd service files * redhat/*.service: add systemd service file for each routing daemon * redhat/quagga.sysconfig: add comment about watchquagga and systemd * redhat/Makefile.am: add systemd service files to distribution Signed-off-by: David Ward <david.ward@ll.mit.edu> Signed-off-by: David Lamparter <equinox@diac24.net>
David WardDavid LamparterDavid Ward
a41242bed82redhat: update initscriptsTaken from Fedora packaging with additional fixes. * redhat/*.init: make all initscripts LSB-compliant; store the daemon configuration file location in $CONF_FILE, and perform existence testing before starting the daemon * redhat/babeld.init: add initscript for Babel routing engine * redhat/quagga.sysconfig: add command-line options for babeld; remove the daemon configuration...
David WardDavid LamparterDavid Ward
0bd268a5232redhat: add logrotate configuration for babeld and isisdSigned-off-by: David Ward <david.ward@ll.mit.edu> Signed-off-by: David Lamparter <equinox@diac24.net>
David WardDavid LamparterDavid Ward
7b0df9c5baddoc: add ospfclient(8) and watchquagga(8) man pagesTaken from Fedora packaging. Signed-off-by: David Ward <david.ward@ll.mit.edu> Signed-off-by: David Lamparter <equinox@diac24.net>
David WardDavid LamparterDavid Ward
f027d331fc2doc: only package man pages for daemons that are builtSigned-off-by: David Ward <david.ward@ll.mit.edu> Signed-off-by: David Lamparter <equinox@diac24.net>
David WardDavid LamparterDavid Ward
2e14a748061tools: use standard interpreter path in all Perl scriptsSigned-off-by: David Ward <david.ward@ll.mit.edu> [changed /usr/bin/perl to /usr/bin/env perl] Signed-off-by: David Lamparter <equinox@diac24.net>
David LamparterDavid Lamparter
fac3c2453a0bgpd: fix up multipath merge breakagethe BGP multipath code was developed against a pre-f6f434b Quagga where bgp_attr_unintern and ecommunity_free took single-star pointers. They now take double-star pointers. * bgpd/bgp_mpath.c: fix up bgp_attr_unintern & ecommunity_free calls. Signed-off-by: David Lamparter <equinox@diac24.net>
Juliusz ChroboczekDavid LamparterJuliusz Chroboczek
27f689793a2babeld: merge kernel_zebra.c into kernel.c.In upstream babel, we include different kernel_foo files depending on the platform we compile for. In Quagga, this is not needed, and it avoids tricky autotools issues. (All autotools issues are tricky.) [David: without this commit, build breaks.] From: Juliusz Chroboczek <jch@pps.jussieu.fr> Signed-off-by: David Lamparter <equinox@diac24.net>
Denis OvsienkoDavid LamparterDenis Ovsienko
61a81bea6d2babeld: Include babel_main.h in noinst_HEADERS.babeld wouldn't build in a dist tarball without this. From: Denis Ovsienko <infrastation@yandex.ru> Signed-off-by: Juliusz Chroboczek <jch@pps.jussieu.fr> [fixed up git message] Signed-off-by: David Lamparter <equinox@diac24.net>
David LamparterDavid Lamparter
8d79efddb9clib: bump ZSERV_VERSION to 2continually changing the zserv protocol without bumping up the version number has made it impossible to talk to zebra without knowing the exact version. in reality, increasing the version number more often guards against inadvertedly running incompatible versions of a daemon and zebra as well as aids external development. * lib/zclient.h: #define ZSERV_VERSION 2 Signed-off-by: David Lampar...
David LamparterDavid Lamparter
9665856e371Revert "zebra: clean up client routes when client goes away"This reverts commit af56d404cd56d94ad3b2ec3f159650eb72baef0a, which was accidentally duplicating functionality from commit 2ea1ab1 "zebra: ZEBRA_HELLO and mopping up routes (BZ#448)" Conflicts: zebra/zebra_rib.c Signed-off-by: David Lamparter <equinox@diac24.net>
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
fa4094ac49bbgpd: Fix crash when disabling dampening (BZ#687) Vladimir Podobaev reported that the following commands crashed the daemon. router bgp 123 bgp dampening no bgp dampening 1 2 3 4 no bgp dampening The problem was that bgp_damp_info_clean() tried to dereference the already freed reuse_list array in the second call to "no bgp dampening". Fixed by checking in bgp_damp_disable() that the dampening it's enabled before doing the cle...
Jorge Boncompte [DTI2]David LamparterJorge Boncompte [DTI2]
7939e016b3dospfd: Fixes a crash of the daemon with a snmp walk - And allows to walk the LSDB. Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
JR RiversDavid LamparterJR Rivers
3cadc0cdebbzebra: use larger buffer (4096) for netlink messagesIncrease the maximum number of nexthops per route by using a larger buffer for netlink messages. * zebra/rt_netlink.c: Use a buffer of 4096 bytes to parse/build netlink messages. Add a hash define for this number (NL_PKT_BUF_SIZE). Most places in the code were previously using a buffer of 1024 bytes.
David LamparterDavid Lamparter
d75318cc8deMisisd: merge osr/google-is-isthis is essentially half of a rewrite of isisd. please note that a lot of things are still broken and isisd is not ready for production use.
Vyacheslav TrushkinDavid LamparterVyacheslav Trushkin
48d8bea8b7cquagga: option "-z" ("--socket <path>") addedAll daemons modified to support custom path to zserv socket. [reapplied from b511468 after isisd merge]
Vyacheslav TrushkinDavid LamparterVyacheslav Trushkin
1627b20fd4fisisd: indent longopts array
David LamparterDavid Lamparter
086695cb8eeisisd: reapply removal of CVS cruftthis re-removes CVS keywords and .cvsignore files. original commits: b82cdeb delete CVS keywords 05e54ee build: delete .cvsignore files
David LamparterDavid Lamparter
6e493a44836Mbgpd: merge osr/quagga-osr-patches (BZ#700)this merges a bgp capability negotiation fix where bgpd would fail if no multiprotocol capability was present, but other capabilities were.
David LamparterDavid Lamparter
9bb5870e26aMbgpd: merge osr/google-bgp-multipaththis patchset allows collapsing multiple received routes in BGP into one multipath route that will, if readvertised, contain an aggregate of all received attributes.
Avneesh SachdevAvneesh Sachdev
aa3b2642826isisd: reapply patch to fix zebra protocolReapply the bits of revision b4e45f6 that pertain to isisd. That is: git log -n 1 -p b4e45f6 -- isisd These were dropped in the merge with the Google ISIS code (14d2bbaa). The commit message for b4e45f6 is: fix zebra protocol after MP-BGP changes The previous commits modified both zebra and bgpd for additional SAFI field, but not any other routing daemon, which led to zebra ...
Avneesh SachdevAvneesh Sachdev
14d2bbaa3f4MMerge quagga mainline into the google ISIS code.The steps were: $ git checkout google-is-is $ git merge quagga $ git checkout google-is-is -- isisd # Resolve conflicts in the following: lib/md5.h zebra/rt_netlink.c zebra/zebra_rib.c zebra/zserv.c Note that the content in the isisd directory is left unchanged in the merge. As a result, changes made to isisd as part of the following commits on the quagga mainline are dropped...
Denis OvsienkoDavid LamparterDenis Ovsienko
a25a44dba84ospfd: adjust OSPF_ROUTER_LSA_MIN_SIZE for VL case
Avneesh SachdevAvneesh Sachdev
3cf6c2b4e43MMerge branch 'quagga' into google-bgp-multipathConflicts: bgpd/bgp_route.c
Avneesh SachdevAvneesh Sachdev
3b381c32fc2bgpd: fix issue in capability negotiation (BZ#700)Address problem where bgpd would reject a session if a peer sent some capabilities in its Open message, but did not include a Multiprotocol extensions capability. Note that the session would come up if there were no capabilities at all in the Open message. * Add the 'mp_capability' out parameter to bgp_capability_parse(). Set it to '1' if a Multiprotocol extensions capability is enco...
Josh BaileyAvneesh SachdevJosh Bailey
51d4ef832c1zebra: include hardware addr in if up/down messagesChange interface up/down notification messages to also include the hardware address of the interface. The format of these messages is now identical to the interface add message -- move the serialization code to common functions. * lib/zclient.c: Modify zebra_interface_if_set_value() to also parse the hardware address. Invoke it from zebra_interface_add_read() and and zebra_interface_...
Josh BaileyAvneesh SachdevJosh Bailey
2dd04c5dc8blib: Tweak to if_delete_retain() * lib/if.c: Change if_delete_retain() to delete all connected addresses, but to not free the list that holds them. Free the list just before the interface structure itself is freed, in if_delete().
Josh BaileyAvneesh SachdevJosh Bailey
af56d404cd5zebra: clean up client routes when client goes away * zebra/zebra_rib.c: Add code to clean up routes added by a client (as identfied by 'rib type'). * zebra/zserv.[ch]: Maintain the type of the routes added by a client on the 'zserv' structure -- assume that a given client uses a single route type for now. Clean up routes from a client when the client goes away (in zebra_client_close()). From: Josh Bailey <joshb@google...