OpenSourceRouting
  1. OpenSourceRouting

quagga-snap

Public
AuthorCommitMessageCommit dateIssues
Denis OvsienkoDenis Ovsienko
7dbeea9d4f4zebra: add missing includes
Denis OvsienkoDenis Ovsienko
87362ceb5d4ospf6d: address more trivial compiler warnings* ospf6_main.c: include required headers * ospf6_asbr.h: idem * ospf6_spf.c * ospf6_spf_install(): remove unused variables
Denis OvsienkoDenis Ovsienko
05b7709dad4ospfd: sizing macros cleanup* ospf_spf.c * ROUTER_LSA_TOS_SIZE: prepend OSPF_ and move to ospf_lsa.h * ROUTER_LSA_MIN_SIZE: replace with existing OSPF_ROUTER_LSA_LINK_SIZE
Dmitrij TejblumDenis OvsienkoDmitrij Tejblum
10d04cdb419lib: use "protocol-independed API" from RFC3678, if that is available(This commit is based on the patch from BZ#420, and should fix that bug.) * configure.ac: detect availability of that API * sockopt.c (setsockopt_ipv4_multicast): use it for join/leave IPv4 multicast groups
Dmitrij TejblumDenis OvsienkoDmitrij Tejblum
ee7e75d38bdlib: futher simplification of setsockopt_ipv4_multicast()* sockopt.c (setsockopt_ipv4_multicast): check for wrong optname with assert(), rather than return an error.
Dmitrij TejblumDenis OvsienkoDmitrij Tejblum
e0afa6f44a7lib: fix omission in the previous commit to lib/sockopt.c* sockopt.c (setsockopt_ipv4_multicast_if): fix missed line in the previous commit.
Dmitrij TejblumDenis OvsienkoDmitrij Tejblum
69bf3a39931lib: simplify interface of setsockopt_multicast_ipv4().* sockopt.[ch] (setsockopt_ipv4_multicast): ifindex is now mandatory (all non-ancient OSes can use it anyway), and if_addr parameter (the address of the interface) is now gone. (setsockopt_ipv4_multicast_if): IP_MULTICAST_IF processing moved to this new function * ospf_network.c (ospf_if_add_allspfrouters, ospf_if_drop_allspfrouters, ospf_if_add_alldrouters, ospf_if_drop_alldrouters, o...
Denis OvsienkoDenis Ovsienko
ea4021984f9ospf6d: spelling
Denis OvsienkoDenis Ovsienko
3a8c3dd7d03lib: remove unused variable* sockopt.c (getsockopt_ifindex): "ifindex" was never used
Denis OvsienkoDenis Ovsienko
b82cdeb18f8delete CVS keywords
Denis OvsienkoDenis Ovsienko
6159928d282configure: fix OpenPAM detection
Denis OvsienkoDenis Ovsienko
9eba2ada189bgpd: check ATOMIC_AGGREGATE attr flags (BZ#678)* bgp_attr.c * bgp_attr_atomic(): accept extra argument, add checks for "optional", "transitive" and "partial" bits, log each error condition independently * bgp_attr_parse(): provide extra argument
Denis OvsienkoDenis Ovsienko
2cfadf09a81bgpd: check MULTI_EXIT_DISC attr flags (BZ#677)* bgp_attr.c * bgp_attr_med(): add checks for "optional", "transitive" and "partial" bits, log each error condition independently
Denis OvsienkoDenis Ovsienko
0ea968d21f1bgpd: check LOCAL_PREF attribute flags (BZ#674)* bgp_attr.c * bgp_attr_local_pref(): accept extra argument, add checks for "optional" and "transitive" bits, log each error condition independently * bgp_attr_parse(): provide extra argument
heasleyDenis Ovsienkoheasley
1212dc1961ebgpd: add useful notification logs (BZ#616)* bgp_packet.c * bgp_notify_send_with_data(): add calls to zlog_info()
heasleyDenis Ovsienkoheasley
d68ab1009f4bgpd: consistent log msg format (BZ#565)
Jon AnderssonDenis OvsienkoJon Andersson
5fdaa04e635ospf6d: add lost lines to area config block* ospf6_area.c * ospf6_area_config_write(): write filter-list, import-list and export-list lines
Christian HammersDenis OvsienkoChristian Hammers
75d044d234dospf6d: fix crash on filter-list handling (BZ#530)This essentially merges the fix available from Debian build of Quagga. * ospf6_area.c * area_filter_list(): use correct argv indices * no_area_filter_list(): idem
Denis OvsienkoDenis Ovsienko
2b43bf231c3configure: fix FreeBSD header detection (BZ#408)This change is based on Xavier Beaudouin's patch (which fixes detection of 3 config.h macros on FreeBSD without any impact to Linux build of Quagga) and FreeBSD port patch (which fixes 5 config.h macros, but breaks the Linux build), it fixes 5 macros and works for both FreeBSD 8 and Linux.
Peter SzilagyiDenis OvsienkoPeter Szilagyi
306ca83213aisisd: include hash.h, not hash.c
Fritz ReichmannDenis OvsienkoFritz Reichmann
89980759568isisd: raise hello rate for DIS (BZ#539)* isis_pdu.c: Divide hello interval by three, depending if we are DIS or not.
Fritz ReichmannDenis OvsienkoFritz Reichmann
5574999e598isisd: fix crash on "no router isis" (BZ#536)The crash is due to threads accessing data that gets destroyed during the removal of the configuration. * isis_circuit.c: Destroy adjacencies to stop adjacency expiry thread. Stop PSNP threads. * isisd.c: Change state of circuit back to INIT and reassign the circuit structure to isis->init_circ_list rather than destroying the circuit data structure. Stop SPF threads. Stop LSP generation ...
Stephen HemmingerDenis OvsienkoStephen Hemminger
b69442d456fconfigure: dismiss libutil.hRecent versions of libc on Linux (Debian Testing) create lots of compile warnings about direct usage of libutil.h
Dmitry PopovDenis OvsienkoDmitry Popov
83d1614952fzebra: fix loss of metric for Linux routes* rt_netlink.c * netlink_route_change(): fetch metric information like netlink_routing_table() does and pass it further
Alexandre ChappuisDenis OvsienkoAlexandre Chappuis
3c9cfcdebf6ospfd: remove useless RFC1583 check* ospf_route.c: Function ospf_asbr_route_cmp is called uniquely from ospf_route_cmp() when the flag OSPF_RFC1583_COMPATIBLE is not set. Therefore, the check that the flag is set doesn't make sense at all and it can consequently be removed without doing any harm. Signed-off-by: Alexandre Chappuis <alc@open.ch> Signed-off-by: Roman Hoog Antink <rha@open.ch>
Alexandre ChappuisDenis OvsienkoAlexandre Chappuis
c31e5726becdoc: BGP route-flap dampening
Alexandre ChappuisDenis OvsienkoAlexandre Chappuis
37075da75dfdoc: add missing word* ospfd.texi: Adjust meaning of the rfc1583compatibility option in order to match the RFC specification and the actual source code.
Denis OvsienkoDenis Ovsienko
0998342b5f7release: 0.99.19
Denis OvsienkoDenis Ovsienko
abc7ef44ca0ospf6d: CVE-2011-3323 (fortify packet reception)This vulnerability (CERT-FI #514840) was reported by CROSS project. ospf6d processes IPv6 prefix structures in incoming packets without verifying that the declared prefix length is valid. This leads to a crash caused by out of bounds memory access. * ospf6_abr.h: new macros for size/alignment validation * ospf6_asbr.h: idem * ospf6_intra.h: idem * ospf6_lsa.h: idem * ospf6_message.h: idem * o...CVE-2011
Denis OvsienkoDenis Ovsienko
09395e2a0e9ospf6d: CVE-2011-3324 (DD LSA assertion)This vulnerability (CERT-FI #514839) was reported by CROSS project. When Database Description LSA header list contains trailing zero octets, ospf6d tries to process this data as an LSA header. This triggers an assertion in the code and ospf6d shuts down. * ospf6_lsa.c * ospf6_lsa_is_changed(): handle header-only argument(s) appropriately, do not treat LSA length underrun as a fatal error.CVE-2011
Denis OvsienkoDenis Ovsienko
71775043383ospfd: CVE-2011-3325 part 2 (OSPF pkt type segv)This vulnerability (CERT-FI #514838) was reported by CROSS project. The error is reproducible only when ospfd debugging is enabled: * debug ospf packet all * debug ospf zebra When incoming packet header type field is set to 0x0a, ospfd will crash. * ospf_packet.c * ospf_verify_header(): add type field check * ospf_read(): perform input checks earlyCVE-2011
Denis OvsienkoDenis Ovsienko
61ab0301606ospfd: CVE-2011-3325 part 1 (OSPF header underrun)This vulnerability (CERT-FI #514838) was reported by CROSS project. When only 14 first bytes of a Hello packet is delivered, ospfd crashes. * ospf_packet.c * ospf_read(): add size checkCVE-2011
CROSSDenis OvsienkoCROSS
6b161fc12a1ospfd: CVE-2011-3326 (uknown LSA type segfault)This vulnerability (CERT-FI #514837) was reported by CROSS project. They have also suggested a fix to the problem, which was found acceptable. Quagga ospfd does not seem to handle unknown LSA types in a Link State Update message correctly. If LSA type is something else than one supported by Quagga, the default handling of unknown types leads to an error. * ospf_flood.c * ospf_flood(): check...CVE-2011
CROSSDenis OvsienkoCROSS
94431dbc753bgpd: CVE-2011-3327 (ext. comm. buffer overflow)This vulnerability (CERT-FI #513254) was reported by CROSS project. They have also suggested a fix to the problem, which was found acceptable. The problem occurs when bgpd receives an UPDATE message containing 255 unknown AS_PATH attributes in Path Attribute Extended Communities. This causes a buffer overlow in bgpd. * bgp_ecommunity.c * ecommunity_ecom2str(): perform size check earlierCVE-2011
Denis OvsienkoDenis Ovsienko
a0bf59bcac8ospf6d: add missing includeTwo extern declarations in ospf6_abr.h are based on struct ospf6_route, which may not be available at the time ospf6_abr.h is included. This may lead to warnings after including ospf6_abr.h just for the structures defined in it.
Denis OvsienkoDenis Ovsienko
ef95122eb21ospf6d: move named constants to ospf6d.h
Denis OvsienkoDenis Ovsienko
d91f35bc90eospf6d: justify some ABR debug code* ospf6_abr.c * ospf6_abr_examin_summary(): only fill "buf" when it is used
Paul JakmaPaul Jakma
538cb284864MMerge remote-tracking branch 'origin/master'
Paul JakmaPaul Jakma
036a6e6cf63MMerge branch 'attr-errors'Contains BGP fixes: - set extcommunity crash: tihs patch tries to make the refcounting more robust but does not fully solve the problem, sadly. - BGP attribute error handling: Little testing.
Greg TroxelGreg Troxel
8ced4e82e6fMMerge remote-tracking branch 'polymorf/master'
Roman Hoog AntinkGreg TroxelRoman Hoog Antink
7e924e11a96fix typo
Greg TroxelGreg Troxel
fe0a1a45c31Omit --opaque-lsa from build (now default).
Dmitrij TejblumDenis OvsienkoDmitrij Tejblum
d42306d98faospf6d: copy "mtu-ignore" option from ospfd"mtu-ignore" is an option ospfd used to mimic from the vendor's implementation, now ospf6d will also implement it. * ospf6_interface.h: extend ospf6_interface structure by one flag * ospf6_interface.c: (ipv6_ospf6_mtu_ignore, no_ipv6_ospf6_mtu_ignore): new declarations; (ospf6_interface_create): show initial value for consistency; (ospf6_interface_show): print flag status * ospf6_message.c...
Paul JakmaPaul Jakma
8dd1a8daae0zebra: trivial warning fix* zebra_routemap.c: (route_set_src) get rid of the dummy family variable.
Paul JakmaPaul Jakma
fdbc8e77c88bgpd: trivial format / warning fixes* bgp_aspath.c: (assegments_parse) just bail early if length doesn't match and fix the formatting. * bgp_network.c: add include needed for set_nonblocking * bgp_packet.c: formatting
Paul JakmaPaul Jakma
072990e22e6ospf: Fix OSPF API and ospf-te LSA refreshers to match recent API change* ospf_apiserver.{c,h}: (ospf_apiserver_lsa_refresher) refreshers must now return the refreshed LSA. * ospf_te.{c,h}: (ospf_mpls_te_lsa_refresh) ditto * ospf_api.c: trivial compiler warning fix
Paul JakmaPaul Jakma
8f6f78a761fMFix authorship of previous ospf6d commit
Ingo FlaschbergerPaul JakmaIngo Flaschberger
57c4f4f45b7ospf6d: fix crash if zebra_interface_state_read can't find interface* ospf6_zebra.c: (ospf6_zebra_if_state_update) zebra_interface_state_read may return NULL, if it can't find an interface, deal with it.
Paul JakmaPaul Jakma
597de5a01a5ospf6d: fix crash if zebra_interface_state_read can't find interface* ospf6_zebra.c: (ospf6_zebra_if_state_update) zebra_interface_state_read may return NULL, if it can't find an interface, deal with it.
Michael LambertPaul JakmaMichael Lambert
604a9b43dd6bgpd: fix memory leak when deleting a community* bgp_routemap.c: (route_set_community_delete) When deleting a community in a route-map the old community was being orphaned. Like the description of the same code in route_set_community, this is a hack, not a true fix.