eigrpd: handle the gr neighbor list safely in update_receiveBe careful handling the gr neighbor list; don't free the
list if it's present in the neighbor struct.
Reported-by: Sin Liang Lee <slee3846@gatech.edu>
Signed-off-by: Mark Stapp <mjs@cisco.com>
nhrpd: fix packet and buffer handling errorsFix some buffer-handling errors in nhrp.
Reported-by: Sin Liang Lee <slee3846@gatech.edu>
Signed-off-by: Mark Stapp <mjs@cisco.com>
bgpd: fix wrong stopping the listening portAfter removing all neighbors from default bgp instance, the listening
port is wrongly stopped.
Fixes commit df7b1910abeedc822343643ac626b6fc84021f9d ("bgpd: Activate listening socket for a default VRF when created")
Signed-off-by: anlan_cs <anlan_cs@126.com>
bgpd: fix missing starting listening portThe listening port also needs to be activated for the interface neighbor, as well
as for the normal neighbor.
Fixes: f8dafef42b694de723df256765df37f8405ef48e ("bgpd: avoid socket activation for VRF instances")
Signed-off-by: anlan_cs <anlan_cs@126.com>
bgpd: correct the display headerUse macro for the display header, just as it is used in other places as well.
Signed-off-by: anlan_cs <anlan_cs@126.com>
tests: fix a regex in all_protos topotestAllow a regex to tolerate a negative value; remove a duplicated
statement.
Signed-off-by: Mark Stapp <mjs@cisco.com>
yang: Revision statements are not given in reverse chronological order at frr-staticd.yangRevision stements are not given in reverse chronological order at frr-staticd.yang
Signed-off-by: y-bharath14 <y.bharath@samsung.com>
tests: Test the new output for `show neighbor'Update the test that looks at the neighbor table
to look for the state value as well now and to
use json and finally to use run_and_expect
as that it will fail.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra: Store state of the neighbor entryStore the state of the neighbor entry and display it
as appropriate.
eva# show neigh
Interface Neighbor MAC #Rules State
enp13s0 192.168.119.120 00:e0:67:21:d5:88 0 REACHABLE
enp13s0 fd5d:a247:468e:10::1 26:5a:4c:59:da:3d 0 REACHABLE
Signed-off-by: Donald Sharp <sharpd@nv...
zebra: Properly break up `show ip neigh``show ip neigh` currently dumps the entire neighbor table,
which of course includes both v4 and v6 neighbor entries.
Modify the code to have `show ip neigh` just dump the v4
neighbor entries.
Add a `show ipv6 neigh` and a `show neighbor` command that
dumps what you would expect.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests: Fix test_ospf_routemaps.py to not use `med`Med is not something that is recognizable by the create_route_maps
functionality. Use metric instead since that is what is intended.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests: Fix test_bgp_always_compare_med_topo1.pyThe setup for adding routemaps was using `med` as a key
value to add a metric. The bgp.py code in lib has no
way to interpret this and as such the routes being
choosen where `oldest path` since there was no metric
to discriminate. Upon heavy load routes would be received
in a unexpected order and the resulting nexthop would be
unexpected. Fix this.
Signed-off-by: Donald Sharp <sharpd@nvidia...
lib: add get_next api for srcdest tablesAdd a srcdest analogue for route_table_get_next(), that takes
a dest and src tuple and looks for the successor route node,
if it exists.
Signed-off-by: Mark Stapp <mjs@cisco.com>
tests: fix some python and test syntaxFix a couple of python escape syntax warnings, and an unknown
pytest mark.
Signed-off-by: Mark Stapp <mjs@cisco.com>
zebra: Modify rib_process_dplane_results to limmit work doneUnder heavy load the rib_process_dplane_results can run for minutes
at a time:
zebra daemon.warning : [R19DC-BSZSS][EC 100663313] CPU HOG: task rib_process_dplane_results (562d04b8be60) ran for 348292ms (cpu time 337021ms)
Add a bit of code to limit this work to a more reasonable
number of items before allowing other processing to happen in FRR.
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
lib/typesafe: avoid __builtin_ctz(0) in skiplist addGuard random level selection in typesafe skiplist add against zero
input before calling ctz to avoid undefined behavior and overflow
allocations.
Signed-off-by: Andreas Florath <Andreas.Florath@telekom.de>
bgpd: fix the local-preference setting for EBGP-OADMake sure the local-preference is set for EBGP-OAD.
Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
bgpd: clear several parameters in subgroup_announce_check()Clear tag, weight and distance in the outbound attribute. Also
clear MED, aigp, and local-preference when appropriate.
This helps avoid unnecessary attributes in the outbound attribute
table, and also helps reduce duplicate updates to neighbors.
Signed-off-by: Enke Chen <enchen@paloaltonetworks.com>
test: update tests to handle compact JSON- Adjust result handling to deal with compact JSON outputs
- Handle changed namespace output from libyang v5
- Update rpc test to not print scary warning on expected result
Signed-off-by: Christian Hopps <chopps@labn.net>
Donald Sharp
Mark Stapp
anlan_cs
Christian Hopps
Y Bharath
Donald Sharp
Enke Chen
Andreas Florath