FRR Mirror
  1. FRR Mirror

FRR

Public
AuthorCommitMessageCommit dateIssues
Mark StappGitHubMark Stapp
0705d288946MMerge pull request #19911 from hnattamaisub/cov_zebra_srv6zebra: Coverity issue (Null pointer dereference)
Harini SubramanianHarini Subramanian
6efc5131b9dzebra: Coverity issue (Null pointer derefence(CID 110225))This commit addresses null pointer dereference in zebra/zebra_srv6_vty.c CID 110225: Dereference null return value (NULL_RETURNS) dereference: Dereferencing zvrf, which is known to be NULL. Description: Handled null check accordingly. Signed-off-by: Harini Subramanian <hnattamaisub@nvidia.com>
Donald SharpGitHubDonald Sharp
108d9b040c7MMerge pull request #19902 from Jafaral/igmp-supress-warnpimd: demote a warning to a debug to avoid spamming the logs
Jafar Al-GharaibehJafar Al-Gharaibeh
8fb28cba7c0pimd: demote a warning to a debug to avoid spamming the logsIf a router/switch keeps sending us a general igmp query with a flag we don't expect, we shouldn't spam the logs, especially if the condition is totally harmless and can be just ignored. Just move it under a debug config. Sample log firing every 15 seconds: ``` 02:10:32 pimd: General IGMP query v3 from 192.168.1.1 on eth0: Suppress Router-Side Processing flag is clear 02:10:47 pimd: General I...
Jafar Al-GharaibehGitHubJafar Al-Gharaibeh
1e498234daaMMerge pull request #19597 from donaldsharp/tests_unifiedConvert a couple of bfd tests to use frr.conf unified config
Russ WhiteGitHubRuss White
81c155b7a1aMMerge pull request #19891 from donaldsharp/peer_group_notify_unconfig_bugbgpd: Notify all incoming/outgoing on peer group notify unconfig
Donatas AbraitisGitHubDonatas Abraitis
95feb82b3d9MMerge pull request #19840 from donaldsharp/show_zebra_client_jsonzebra: Add `show zebra client json` command
Russ WhiteGitHubRuss White
8fca2cf134cMMerge pull request #19695 from aprathik04/zebra_uncheck_return_coverityzebra: fix for unchecked return value coverity issues
Donald SharpDonald Sharp
051b5db1a75tests: Convert bfd_isis_topo1 and bfd_ospf_topo1 to unified configStart the conversion of some tests to using a unified config for bfd. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donald SharpDonald Sharp
e0465f17aa7tests: Allow bfdd to be part of the unified config worldThe unified config loader was not properly handling bfdd. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donald SharpGitHubDonald Sharp
2edcc1e5afaMMerge pull request #19807 from anlancs/fix/zebra-fpmzebra: fix missing fpm messages
Donald SharpDonald Sharp
72102e248bbzebra: Add `show zebra client json` commandAdd the ability to grab data about the `show zebra client` command as json. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donald SharpGitHubDonald Sharp
c91e105668cMMerge pull request #19886 from opensourcerouting/fix/coverity_bfdbfdd: Return an error before using negative fd for setsockopt()
Donatas AbraitisGitHubDonatas Abraitis
29eb3bc1394MMerge pull request #19879 from soumyar-roy/soumya/evpn_attr_crashbgpd: Crash due to usage of freed up evpn_overlay attr
Donatas AbraitisDonatas Abraitis
f1d2cc0a7d8bfdd: Return an error before using negative fd for setsockopt()"sd" is passed to a parameter that cannot be negative for bp_set_ipopts(). Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas AbraitisGitHubDonatas Abraitis
639779a4cccMMerge pull request #19861 from hnattamaisub/vrrpvrrpd: IPv6 VRRP macvlan doesn't have IPv6 link-local address
Soumya RoySoumya Roy
8b087b2a439bgpd: Crash due to usage of freed up evpn_overlay attrReason: Use-after-free in evpn_overlay due to incorrect reference counting when storing routes in Adj-RIB-In. 1) In bgp_update_receive, we parse the attributes first in bgp_attr_parse_ret and it will intern those attributes, so refcnt for them would become 0->1. We can't do evpn_overlay attribute processing here, as it requires NLRI/EVPN knowledge, which happens via bgp_nlri_parse lat...
Mark StappGitHubMark Stapp
e5d87b1abb2MMerge pull request #19811 from donaldsharp/startup_zebra_testingInterface speed handling improvements
Donald SharpDonald Sharp
82fc14fd5b4bgpd: Notify all incoming/outgoing on peer group notify unconfigThe peer_group_notify_unconfig function was only sending Notification to either the incoming or outgoing connection, but not both. If you are in early stages of bringing up a neighbor on both incoming and outgoing connections. If the cli is changed that something about a peer group changes the code is only notifying either incoming or outgoing, but not both. If we need to reset the connections...
Donald SharpGitHubDonald Sharp
a47f995f4ffMMerge pull request #19856 from mjstapp/dplane_version_10_5zebra: update dataplane api version for 10.5 release
Donald SharpGitHubDonald Sharp
7270576445eMMerge pull request #19868 from opensourcerouting/fix/route_map_counter_decrement_srv6bgpd: Track route-map references for srv6 when rmap is used
Mark StappGitHubMark Stapp
7776f8ed9d0MMerge pull request #19842 from donaldsharp/hmac_stuffospfd: Drop support for SSL1 and update to SSL3
Russ WhiteGitHubRuss White
067f7d9b459MMerge pull request #19710 from vijayalaxmi-basavaraj/bgp_vrf_routemapbgpd: BGP_CONFIG_VRF_TO_VRF_IMPORT flag not set correctly
Donatas AbraitisGitHubDonatas Abraitis
039fe9c98acMMerge pull request #19848 from fdumontet6WIND/extcomm_listtest: bgp_extcomm_list_delete add regex case
Donatas AbraitisGitHubDonatas Abraitis
384f2db0466MMerge pull request #19851 from hnattamaisub/zebra_null_covzebra: Null pointer dereferences (medium)
Donatas AbraitisGitHubDonatas Abraitis
e0eb974e53aMMerge pull request #19863 from aprathik04/pbr_memleakpbrd: fix memleak during pbr map deletion
Donatas AbraitisGitHubDonatas Abraitis
3606c13f15cMMerge pull request #19869 from hnattamaisub/high_covbgpd: High coverity changes - Uninitialzed scalar variable
Donatas AbraitisGitHubDonatas Abraitis
7f9da407131MMerge pull request #19870 from donaldsharp/cluster_length_weirdnesstests: Add a cluster-length test
Donatas AbraitisGitHubDonatas Abraitis
4238e8d0f1aMMerge pull request #19871 from donaldsharp/bgp_connection_event_cleanupbgpd: Double check all connection events are stopped on peer shutdown.
Harini SubramanianHarini Subramanian
6893021629avrrpd: IPv6 VRRP macvlan doesn't have IPv6 link-local addressProblem description: In some race conditions, vrrp doesnot get newlink update notifications from zebra. Fix: Kernel flags are updated in ifp->flags in all scenarios as per our code though protodown is set. So when proto is coming up, is_up has already set when kernel sends UP status even when protodown happened so it is called with false instead of true. Made code changes accordingly to send t...
Donald SharpGitHubDonald Sharp
e7f029862e3MMerge pull request #19351 from maxime-leroy/frr_headersFrr headers
Donatas AbraitisDonatas Abraitis
b3e1cf887e8tests: Rename bgp_route_map_unused to route_map_check_unusedThis is going to be extended in the future not only for BGP, so let it be more generic. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donald SharpDonald Sharp
502fc4c2463bgpd: Double check all connection events are stopped on peer shutdown.We have a address sanitizer issue where a event is directly leaked that is related to the connection for a peer. At this point I cannot make the problem happen nor can I come up with a scenario where this is even possible. But the peer removal code is playing a bit loose with the connection events. Let's just go through all of them and ensure that they are all stopped. Signed-off-by: Donald...
Donald SharpDonald Sharp
22560bdb0bftests: Add a cluster-length testUpon examination of the gcoverage I noticed that there were no tests that ensure that the cluster-length is working as expected. I've added this test. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Donatas AbraitisDonatas Abraitis
a20eeaf5d15tests: Check if `show route-map-unused` works as expectedSigned-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas AbraitisDonatas Abraitis
fe50db0de10lib: Add JSON support for `show route-map-unused` commandSigned-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas AbraitisDonatas Abraitis
c52f9e5d118doc: Add `show route-map-unused` commandSigned-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Russ WhiteGitHubRuss White
26138888850MMerge pull request #19745 from anlancs/fix/ospfd-rcv-changed-lsidospfd: fix the inconsistency between lsdb and route table
Christian HoppsGitHubChristian Hopps
cff2068eb71MMerge pull request #19715 from nishant111/nishant/frrEventSchedulingFixlib : Set the correct timeout attribute in ppoll
Harini SubramanianHarini Subramanian
fdd34573e39Bgpd: High coverity changes - Uninitialzed scalar variableThis commit addresses uninitialised variable issue in bgp_updgrp_packet.c CID 12282: Uninitialized scalar variable (UNINIT) uninit_use_in_call: Using uninitialized value *tx_id_buf as argument to %s when calling zlog_ref Description: Initialised the same. Signed-off-by: Harini Subramanian <hnattamaisub@nvidia.com>
Francois DumontetFrancois Dumontet
c2a19323e4atest: bgp_extcomm_list_delete add regex casecurrently the "delete" operation on "extcommunity-list expanded" (ie regex selected) case is not tested. we added a step in bgp_extcomm-list_delete scenario Signed-off-by: Francois Dumontet <francois.dumontet@6wind.com>
NishantNishant
85e459f89aclib: Set the correct timeout attribute in ppollfd_poll does not honor timer_wait less than 1000usec which causes ppoll to spin until timer_wait ticks to 0 causing high CPU. Also, set 1 msec floor to poll() to not let poll() spin as well for tv_usec < 1000 and > 0. Also moving timeout related if-else ladder into #else poll compilation to not hit SA cland dead code warning. Signed-off-by: Nishant <nshntsharma86@gmail.com>
Aprathi KAprathi K
8ddecd6ae9apbrd: fix memleak during pbr map deletion1. Free memeory pbrms->src, before free is done for pbrms 2. Free lists pbrm->incoming and pbrm->seqnumbers before pbrm is deleted. 3. Change pbr_map_interface_list_delete to only free up memory for pbr_map_interface. pbr_map_interface_list_delete at present, sends the (pbr_map_seq, interface) delete to zebra and then frees up pbr_map_interface memory. This zebra update is redu...
Donatas AbraitisDonatas Abraitis
9fc8ecb81e5bgpd: Track route-map references for srv6 when rmap is usedWhen we have something like: ``` address-family ipv4 unicast sid export auto route-map test exit-address-family ``` show route-map-unused never shows that this `test` route-map is used. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Donatas AbraitisGitHubDonatas Abraitis
bbaab1fa9bbMMerge pull request #19858 from chiragshah6/bgp_dev6bgpd: EVPN fix memleak in adv type5 cli cmd
Donatas AbraitisGitHubDonatas Abraitis
d8fd4fe2479MMerge pull request #19846 from chiragshah6/zdev2zebra: EVPN fix show interface vxlan json
Donatas AbraitisGitHubDonatas Abraitis
ed5f89e4a18MMerge pull request #19843 from Pdoijode/pdoijode/nbr-debug-detailAdd debug bgp neighbor-events detail command
Chirag ShahChirag Shah
bea58d4aff0bgpd: EVPN fix memleak in adv type5 rmapFree the route-map from bgp instance deletion, and decrement reference when free is called from cli ==1239068== 12 bytes in 2 blocks are definitely lost in loss record 1 of 3 ==1239068== at 0x48417B4: malloc (vg_replace_malloc.c:381) ==1239068== by 0x4C83999: strdup (strdup.c:42) ==1239068== by 0x49437DC: qstrdup (memory.c:123) ==1239068== by 0x24816F: bgp_evpn_advertise_type5 (bgp...
Donald SharpGitHubDonald Sharp
c6951b7a709MMerge pull request #19857 from sri-mohan1/srib-25-bgp-abgpd: changes for code maintainability
Chirag ShahChirag Shah
60c5d1b5de1zebra: EVPN fix show interface vxlan jsonThe VxLAN device can be SVD or non-SVD mode. TVD: Traditional VxLAN Device where one VLAN and VNI mapped under the VxLAN device. SVD: Single VxLAN Device where multiple VLAN and VNI mappins exists. The current show interface vxlan-device command displays only one of the mapping for SVD rather than all mapped VNI information like it does in non-json output. The change in json hierarchy is requ...