lib,zebra,bgpd: Fix for nexthop as IPv4 mapped IPv6 addressAdded a macro to validate the v4 mapped v6 address.
Modified bgp receive & send updates for v4 mapped v6 address as
nexthop and installing it as recursive nexthop in RIB.
Minor change in fpm while sending the routes for nexthop as
v4 mapped v6 address.
Signed-off-by: Kaushik <kaushik@niralnetworks.com>
doc: Add documentation for the new cliDocument the `show bgp ipv4 uni neighbors 192.168.161.2 bestpath-routes`
command.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd: Add `bestpath-routes` to neighbor commandAdd the ability to list the bestpath-routes to the
`show bgp afi safi neighbor X` command.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd: Add to neighbor prefix-counts the count of best path selectedWhen we have a prefix that has been selected, note that that
particular flag has been set and give that information to the
end user.
eva# show bgp ipv4 uni neighbors 192.168.161.131 prefix-counts
Prefix counts for 192.168.161.131, IPv4 Unicast
PfxCt: 814246
Counts from RIB table walk:
Adj-in: 0
Damped: 0
Removed: 0
History: 0
...
nhrpd: ignore zebra updates about our routes being deleted/addednhrp listens for route entries to be deleted, in case some new routes
impact the current routes installed by nhrp. To prevent from
unconfiguring nhrp shortcut route, just prevent nhrp routes to be
processed.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
tests: Avoid top ecmp route_scale test case when memory limitedAddress-sanitizer runs in the CI appear to require more
memory than is available (at present), so skip the top
x32 route_scale testcase when running with <4G of ram.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
tests: rework route_scale topotestMake some changes to the route-scale topotest, in view of
issue #6734. Table-drive the test to eliminate some
repeated code. Assert and fail if a step in the progression
of scale fails. Wait a little longer between checking the show
output - it's costly to generate that output at scale. Add a
memleak testcase.
Signed-off-by: Mark Stapp <mjs@voltanet.io>
ospfd: Fix Zebra route add message truncation issueThe `INET_ADDRSTRLEN` is 16 and is only enough to format an IPv4 address.
So when there is a prefix (`/xx`), the debug output may get truncated.
Use `PREFIX2STR_BUFFER` macro instead to fix the issue.
Signed-off-by: Aaron LI <aly@aaronly.me>
tests: Skipping evpn_type5_test_topo1 tests from CI runs1. evpn_type5_test_topo1 tests started failing in CI for all Ubuntu 18.04 machine,
which are having kernel version: 5.4.0-42-generic
2. We will enable these tests once issue is found and fixed.
Signed-off-by: Kuldeep Kashyap <kashyapk@vmware.com>
zebra,fpm: serialize zebra table walksWe were not getting any benefits from attempting to walk all tables at the
same time and it made debugging harder, so lets execute one table walk
per time.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
zebra,fpm: fix race on completion detectionZebra runs on a different thread than FPM, so we need to synchronize
them by using events. While here, implement completion detection for all
kinds of walk.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
zebra,fpm: fix input handlingTwo important fixes:
* `stream_read_try` does a dirty trick and converts the `-1` return to
`-2` when errno is `EAGAIN`, `EWOULDBLOCK` or `EINTR`.
* Don't enable reads until the connection is complete.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
bgpd: Bypass SA tests regarding division by zero for reuse_limit in dampeningreuse_limit can't be zero basically, Coverity just does not know how the
value comes in.
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
tests: Remove 'log monitor' from testsThe `log monitor' command is a no-op and actually
outputs a `this doesn't do anything` warning. Let's remove
this cli line from our tests as that don't do anything and
people will look at these configs for guidance.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
doc: Remove `Cisco Compatability` sectionThis code was deprecated in 5.0 and removed after a year.
It has not been in the code base and we forgot to update the
doc.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd: Deref after null check in bgp_evpn_vty.cCoverity has noticed that we are using bgp_evpn after
we have already NULL checked it one time. Add an assert
to make Coverity happy here, if we get to this point
something terrible has happened.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd: Prevent Null pointer usageCoverity rightly points out that bgp_table_top might return
NULL and immediately deref'ing it might be a problem.
Add a bit of safety.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd: Comment out dead code for futureI wanted to preserve the old code flow to see what might
be needed in the future in commit:
23ca3269da5f9d898cb54d42c560d519b9cb9915
Coverity doesn't like dead code. So let's comment it out.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
vrrpd: Make clang 11 happyRecent changes to remove PRIu... in commit:
6cde4b45528e52819c803de92d10d4be3abddf29
causes clang 11 to be unhappy, with length of field warnings.
Modify the offending code to compile properly using that compiler.
I've tested against clang 11 and gcc 9.3
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
doc: Add doc for `coalesce-time` in bgpThe documentation for this command was missing. Add a little
bit of data for people in the future.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Stephen Worley
Kaushik
Donald Sharp
Chirag Shah
Philippe Guibert
Mark Stapp
Aaron LI
Kuldeep Kashyap
Rafael Zalamena
