lib: avoid default vrf name memory allocation at startupIf default VRF is used, with standard naming convention,
memory allocation can be avoided.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
lib: protect newly created vrfs against default vrf naming.Prevent from creating vrf, if the default vrf name is the same as the
vrf to be created.
Also, prevent at startup from creating default vrf with a name already
used in vrf list.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
lib: set default vrf name at startupFor the daemons that do not use vrf_init(), the call to the define
will return a default vrf if no other values has been overriden.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
bgpd: handle vrf aliases in vty APIBecause a VRF name can be used for default VRF, or an alias of an
already created VRF can be passed as parameter, the default VRF name
must be found out. This avoids creating double BGP instances for
example.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
ospfd: adaptations to handle vrf aliasSome adaptations are done to handle alias when creationg ospf instance.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
bgpd: authorize default vrf name usageNow it is possible to configure BGP default instance by using its
default vrf name.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
zebra: detect if a netns is the default netnsIn the case the default netns has a netns path, then a new NETNS
creation will be bypassed.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
*: add a vrf update hook to be informed of the vrf nameThe Vrf aliases can be known with a specific hook. That hook will then,
from zebra propagate the information to the relevant zapi clients.
The registration hook function is the same for all daemons.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
lib: autocomple vrf list authorises default vrf nameNow it is possible to dump default vrf information by its name.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
lib: offer an API to get and set default vrf nameThe get API is used each time the VRF_DEFAULT_NAME macro is used.
The set API is not yet used.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
pimd: Add some more useful data to debug outputEnd user was seeing this debug but we are not giving
the user enough information to debug this on his own.
Add a tiny bit of extra information that could point
the user to solving the problem for themselves.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra: No prototype and uninited variablesAdd a header to cleanup no declaration and properly
wrapper some variables to appropriate #ifdef.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
lib: Cleanup uninted `top` variable in ferr.cThe `top` variable could possibly be used without
any initialization, remove the possibility.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
isisd: Include header for function declarationisis_handle_pdu is called but not declared for usage
by not including the appropriate header.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra: Add support for static encap mpls labelsWe were ignoring mpls labels encapped with static routes.
Added support for single and multipath labels.
Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
watchfrr: fix global restartwatchfrr needs to handle a SIGCHLD also when it calls a global restart
command. Before this patch, it would lead to the following behavior:
15:44:28: zebra state -> down : unexpected read error: Connection reset by peer
15:44:33: Forked background command [pid 6392]: /usr/sbin/frr.init watchrestart all
15:44:53: Warning: restart all child process 6392 still running after 20 seconds, sending si...
staticd: refcount the nht add/removalWhen we add / remove a nexthop that we need to track,
keep track of the number of times we have done this
for each nexthop. Consequently keep track of the
number of available nexthops, so that we can
just install new routes when we get one
that uses a pre-existing nexthop. Deletion of
nexthops is done on refcount going to 0.
Removal of routes is handled elsewhere for removal.
Signed-off-by: ...
zebra: When registering a nexthop, we do not always need to re-evalThe code prior to this change, was allowing clients to register
for nexthop tracking. Then zebra would look up the rnh and
send to that particular client any known data. Additionally
zebra was blindly re-evaluating the rnh for every registration.
This leads to interesting behavior in that all people registered
for that nexthop will get callbacks even if nothing changes.
Modify the code to k...
lib: remove Linux 2.4 TCP-MD5 supportLinux 2.6.0 was released in December of 2003... I'm pretty sure we don't
need this Linux 2.4 support anymore.
Signed-off-by: David Lamparter <equinox@diac24.net>
build: drop unused SMUX client OID MIBsThese MIB OIDs were only used to identify clients on the SMUX protocol.
And even for that, they were essentially pointless.
Signed-off-by: David Lamparter <equinox@diac24.net>
doc/user: add protocols vs. platform tableA nicely-formatted colorful table of all our daemons and target OS'.
Based off & intended to replace / extend
https://github.com/FRRouting/frr/wiki/Features-and-Kernel-Support
Signed-off-by: David Lamparter <equinox@diac24.net>
ospfd: interface speed change during intf addThe problem is seen where speed mismatch caused ECMP route
not being reflected with correct number paths (NHs).
During cold boot, some interface speed updated by zebra as
part of one shot timer and triggers interface add to clients.
In this case, ospf already have created interface (bond interface),
but speed was not updated, trigger to do interface speed change
as part of interface add, which...
bgp: Add documentation for IANA well-known communitiesCoded as part of #2684 and most code written while participating at
BornHack@2018.
bgp_route.c: Changes regarding adding explanations for the IANA
well-known communities added in #2684
Signed-off-by: Christoffer <netravnen@gmail.com>
doc: Add documentation for IANA well-known communitiesCoded as part of #2684 and most code written while participating at
BornHack@2018.
bgp.rst: Explain what the communities does and a summarized edition of
the communities purpose.
Signed-off-by: Christoffer <netravnen@gmail.com>
bgpd: Fix CONFDATE to 2019 for a couple of items.While perusing CONFDATE I noticed that we had a couple
CONFDATE 201805, which we were not picking up( for other
reasons and fixed in a different PR ). But upon investigation
of these I noticed that the commits where in 201805, so these
CONFDATES should be in 2019
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
doc, lib, zebra: Remove deprecated encode and decode functionalityThe ZEBRA_IPV4_ROUTE_[ADD|DELETE] and ZEBRA_IPV6_ROUTE_[ADD|DELETE] functionality
has been deprecated for a year now, let's remove this code from the system.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
zebra: Remove unmaintained and uncompilable codeThe zebra/client_main.c code is not being maintained or used.
Remove from system. Especially since the encode/decode
zapi functionality it `purports` to be testing is deprecated
and now being removed.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
lib: Convert vrf bit-map to a hash.Memory sizes of the vrf bit-map was insane for a system
with a moderate number of data on it:
Zebra:
VRF bit-map : 601 65536 39391944
Having a full 32bit integer bit space is problematically large,
switch over to a hash to store bit data. We do not need to waste
so much space.
VRF bit-map : 13 8 312
Signe...
Merge pull request #2854 from chiragshah6/evpn_dev1zebra: Evpn mark router flag as part of neighbor update from kernel
(Merge in proxy reliant on @srimohans' review.)
bgpd: fix rpki exit commandIf a command returns a nonzero exit status and VTYSH has a corresponding
command, VTYSH will skip executing its own version. If this happens in a
command that changes CLI nodes we get node desynchronization.
Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Philippe Guibert
David Lamparter
Donald Sharp
Christian Franke
David Lamparter
Chirag Shah
Christoffer
Don Slice
Quentin Young