Updates the used public rpki-caches for testing environmentMotivation
- get pipeline checks running
How:
- find valid rpki-cache which runs also rtr
- edit url in live_tests
rtr_mgr: replace mutex with rwlockrtr_mgr could enter a deadlocked state with multiple socket groups when
a group with at least one group of lower preference comes back online.
This happens because the thread of the group coming back online blocks
on trying to shut down all threads with lower preference while holding
the rtr_mgrs mutex, but a thread that tries to acquire that same mutex
cannot be shut down while doing so.
Sinc...
redhat: Fix RPM file to work on Fedora 33+ and RedHat 9+- Newer Fedora/RedHat changes cmake rpm build to build out of tree
and requires the use of macros for correct locations
See https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds
- On newer Fedora, the SOURCES subdirectory isn't created
automatically and needs to be created in the prep phase before
the tar is created
Signed-off-by: Martin Winter <mwinter@opensourcerout...
rtrlib/rtr_mgr: properly cleanup rtr_sockets on stop (#268)Previously rtr_sockets could not be restarted because their state
remained on SHUTDOWN, which they can, by design, not recover from
themselves.
tests: Add integration and unit tests for BGPsec.The integration tests cover:
- originating a BGPsec path
- signing a BGPsec path
- validating a BGPsec path
- getting BGPsec version and algorithm suite values
The unit tests cover:
- allocator and initializer functions
- utility functions
rtrlib/bgpsec: Add BGPsec validation features.- The BGPsec API allows to validate and sign BGPsec paths.
- Currently supported BGPsec version is 0.
- For cryptographic operations, OpenSSL is used. Both version 1.0 and 1.1 are supported.
- The router keys necessary for validation are fetched from the SPKI.
rtrlib/transport/ssh: check for all relevant return values of ssh_channel_selectssh_channel_select can return SSH_EINTR, SSH_ERROR and SSH_OK.
Handle SSH_EINTR and SSH_ERROR accordingly and continue for SSH_OK.
rtrlib/transport/ssh: fix constant spinning on recvThe timeout in the tr_ssh_recv implementation was hard coded to 1 second,
instead of using the provided timeout.
rtrlib/transport/ssh: fix deprication warninglibssh has deprecated ssh_is_known_server, ssh_session_is_known_server
should be used instead. It is available since version 0.8.0, we will use
it if available.
rtrlib/transport/ssh: ensure private key or password is setIt does not make much sense to set both in non interactive
authentication, but one of them has to be set.
cmake: use FindPkgConfig to search for libssh availabilityPreviously a homegrown find script was used. That made assumptions
about location of some header files that do not hold true anymore for
recent libssh versions. The canonical why of finding libraries is
pkg-config and cmake has excellent support for that. So we simply use
it.
rtrlib/transport/{tcp,ssh}: fix tr_{tcp,ssh}_open blocking socket stopSince the move from pthread_kill to pthread_cancel a rtr_socket could
not be stopped immediately if it was in the tr_open call.
cancelability could not be enabled for that function because it holds
local resources.
This enables cancalability locally for the only blocking call in
tr_tcp_open and tr_ssh_open respectively.
rtrlib/transport/tcp: add extended errno outputtr_tcp_open outputs the error with strerror instead of gai_strerror
in case an EAI_SYSTEM error code is received.
tools: fix covery issue related to tr_[tcp,ssh]_config initialisationthe structures tr_tcp_config and tr_ssh_config were not set to 0 at
startup, when init_sockets() call is done. handle this by initialising
those structures.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
rtrlib: ability to pass configured socket in tcp/ssh attributeThanks to previous commit, it becomes possible by the caller to add
an an optional opaque pointer, as well as a callback function that
will be in charge of providing a file descriptor that will be used to
create the tcp/ssh connection to the server. If the information is
provided, and if the socket returned is invalid (<=0), then a fallback
mechanism is done, that is to say that the socket is c...
*: add two attributes to [tcp/ssh]_config structurethose two attributes will be further used to store an opaque pointer, as
well as a callback function. it will be up to the user of the API to use
those fields to provide a socket that will be used for rpki
transportation for communication with servers.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
*: fix warnings of compilation with gcc 5.4some warnings are removed by adding some tiny modifications in the code.
third party files are omitted in the warnings fix.
also there is a warning in travis when braces are put around fgets(){}
call, whereas the warning had disappeared with gcc 5.4. decision is to
keep gcc warning for this case, so that travis does not warn.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
add git blame ignore listThis adds a ignore list for git blame. It contains commits that
reformatted large portions of the code without adding any features or
fixing bugs. This aims to make git-blame more readable.
It can be used with git 2.23 or newer in the following way:
git blame --ignore-revs-file .git-blame-ignore $file
tests: manually sort cmocka include and disable clang it from clang-formatThe cmocka header relies on transitive includes to work, the include
order must not be changed.
tools: generate template.h in build folderThe template.h is generated when building the rtr tools.
The resulting file is now create in the build and not the
source directory. This avoids that template.h shows up in
`git status` and also that someone might commit the file
in to the repo by accident.
Nils Bars
maurim
Zopolis4
Marcel Röthke